Wireshark-commits: [Wireshark-commits] master 0002424: Remove most of the tvb_get_ptr calls in the

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 27 Feb 2015 07:42:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0002424f97774168b50f5995e2e18fa900b1a71f
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0002424 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Remove most of the tvb_get_ptr calls in the packet-batadv.c dissector.
    
    These calls were all getting ether addresses which can be gotten by other means.
    
    Change-Id: I9a3d564483c9ee9b8e5183bb9086da8a315c41fc
    Reviewed-on: https://code.wireshark.org/review/7421
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  14697b8   Pass tvb and offset into print_nsap_net() and print_area() to "hide" the tvb_get_ptr call that dissectors are using.
    adds  0002424   Remove most of the tvb_get_ptr calls in the packet-batadv.c dissector.


Summary of changes:
 epan/dissectors/packet-batadv.c |  294 +++++++++++++++------------------------
 1 file changed, 113 insertions(+), 181 deletions(-)