Wireshark-commits: [Wireshark-commits] master 3e5c0bf: Qt: Fix packet detail and byte view scrollin

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 26 Feb 2015 17:22:48 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3e5c0bffa251d97a0fad751af610a92eb76e8b36
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3e5c0bf by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Fix packet detail and byte view scrolling
    
    Make sure we call scrollToByte ByteViewText::setFieldHighlight.
    Explicitly scroll to our selected QTreeWidgetItem in
    ByteViewText::mousePressEvent.
    
    Bug: 11013
    Change-Id: I0a6381f6760ed48a4f496be8a06b1e56faa5a05b
    Reviewed-on: https://code.wireshark.org/review/7416
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  123be13   ANSI IS-637 A: ensure that num_fields is not null before calling text_decoder
    adds  3e5c0bf   Qt: Fix packet detail and byte view scrolling


Summary of changes:
 ui/qt/byte_view_text.cpp |    2 ++
 1 file changed, 2 insertions(+)