Wireshark-commits: [Wireshark-commits] master-1.12 10c1634: Make the _offset values static constant

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 25 Feb 2015 08:14:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=10c1634feb0655909d563a33b90f17629eb2cf86
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

10c1634 by Guy Harris (guy@xxxxxxxxxxxx):

    Make the _offset values static constants.
    
    No need to export them outside this file, and making them constants
    might convince the compiler not to bother fetching their values from
    memory when referring to them.
    
    Change-Id: Ic110513393a303036aa0b7980a0e8776500ab3b0
    Reviewed-on: https://code.wireshark.org/review/7379
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  8499a9f   Have a PACKET_DESCRIBE() for V30's seek-read routine.
    adds  10c1634   Make the _offset values static constants.


Summary of changes:
 wiretap/netscaler.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)