Wireshark-commits: [Wireshark-commits] master ced6fba: Revert "exntest: Fix Dead Store (Dead assign

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 24 Feb 2015 19:34:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ced6fbaae4a09ed2fd74cd6669118637fea78055
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ced6fba by Guy Harris (guy@xxxxxxxxxxxx):

    Revert "exntest: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang"
    
    This reverts commit f9fc25241ca0c735c0945bebf04669f17c3ffbff.
    
    Apparently, clang is wrong about those increments being dead, as the tests done by exntest fail as a result of this change. Perhaps it doesn't understand setjmp/longjmp.
    
    Change-Id: I248fba972e52bcbc97a228777139ca22a835f4b6
    Reviewed-on: https://code.wireshark.org/review/7347
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  c280a40   Qt: Escape ampersands in checkboxes and radio buttons.
    adds  ced6fba   Revert "exntest: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang"


Summary of changes:
 epan/exntest.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)