Wireshark-commits: [Wireshark-commits] master 2899cf4: Don't add redundant information to the top-l

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 23 Feb 2015 20:16:59 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2899cf40f35289a4dc56744a5b5d6e41c7f83c54
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2899cf4 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't add redundant information to the top-level flags item for NBNS.
    
    We already add the opcode, a "this is a response" indication for
    responses and, for non-WACK responses, the response code.  No need to
    add it again.
    
    Change-Id: I2dd0f937568057a96cd70511c872f811ea838106
    Reviewed-on: https://code.wireshark.org/review/7331
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  255de16   RSVD: add missing initialization of lun parameter
    adds  2899cf4   Don't add redundant information to the top-level flags item for NBNS.


Summary of changes:
 epan/dissectors/packet-nbt.c |    5 -----
 1 file changed, 5 deletions(-)