Wireshark-commits: [Wireshark-commits] master-1.12 afc48b4: FT_{U}INT64 doesn't work with BASE_CUST

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 22 Feb 2015 02:49:07 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=afc48b4d2153af6bff8efcba7f0427e7e3e8698e
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

afc48b4 by Guy Harris (guy@xxxxxxxxxxxx):

    FT_{U}INT64 doesn't work with BASE_CUSTOM.
    
    This is the 1.12 branch, so we do a quick fix:
    
    Get rid of the one place we're using it.
    
    Reject it in tmp_fld_check_assert(), so using it will blow up early in
    the initialization process rather than blowing up when dissecting.
    
    In cases that, with the tmp_fld_check_assert() change, "should not
    happen", and where we might *not* be executing in the context of a
    dissector (filling in the field label can be done lazily, being deferred
    to "print" time, and that doesn't happen in the context of a dissector),
    use g_assert_not_reached() rather than DISSECTOR_ASSERT_NOT_REACHED() -
    the latter throws an assertion that's not caught if we're not doing
    dissection, so we crash anyway.
    
    Bug: 10983
    Change-Id: Id4cb1b8ed17cab976b8151e41ec6b6b79478214d
    Reviewed-on: https://code.wireshark.org/review/7304
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  aee8075   http: properly calculate end of chunked response
    adds  afc48b4   FT_{U}INT64 doesn't work with BASE_CUSTOM.


Summary of changes:
 epan/dissectors/packet-lldp.c |   42 ++++++++++++++++++++---------------------
 epan/proto.c                  |   18 ++++++++++++------
 2 files changed, 33 insertions(+), 27 deletions(-)