Wireshark-commits: [Wireshark-commits] master 65763cf: Try to fix diagnostic suppression.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 14 Feb 2015 22:55:04 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=65763cf6acb14d41ffbf37213268b2f64038e4f9
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

65763cf by Gerald Combs (gerald@xxxxxxxx):

    Try to fix diagnostic suppression.
    
    Test the compiler for "-Wpedantic" instead of "-pedantic" since DIAG_OFF
    and DIAG_ON expect a "-W" flag prefix. Be more strict about the compiler
    versions that DIAG_OFF and DIAG_ON support.
    
    Change-Id: I9304c544912102f1719b79e9250f97b40a324430
    Reviewed-on: https://code.wireshark.org/review/7123
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  1b43a80   Note why some header checks are done even if unnecessary on UN*X.
    adds  65763cf   Try to fix diagnostic suppression.


Summary of changes:
 CMakeLists.txt           |    2 +-
 configure.ac             |    2 +-
 wsutil/ws_diag_control.h |   39 ++++++++++++++++++++-------------------
 3 files changed, 22 insertions(+), 21 deletions(-)