Wireshark-commits: [Wireshark-commits] master-1.12 56a5143: Gryphon: do not use col_set_str with no

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 12 Feb 2015 15:20:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=56a514395701deb907713b9eac46d3b142102e1a
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

56a5143 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Gryphon: do not use col_set_str with non constant strings
    
    Fixes an ASAN failure reported by Alexis
    
    Change-Id: I68e5c55ec4090766ef5f003f44093ce3c268a82a
    Reviewed-on: https://code.wireshark.org/review/7082
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    (cherry picked from commit ef21740e25f6e9c759852844fec8507e8c80f4dd)
    Reviewed-on: https://code.wireshark.org/review/7083
    

Actions performed:

    from  f651c8d   Do not iterate over reported length when using tvb_find_line_end
    adds  56a5143   Gryphon: do not use col_set_str with non constant strings


Summary of changes:
 plugins/gryphon/packet-gryphon.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)