Wireshark-commits: [Wireshark-commits] master a837570: Combine SSE and pre-compiled patterns for fa

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 11 Feb 2015 09:14:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a837570d02dca2ad94ff5046b13592d84a12a345
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a837570 by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    Combine SSE and pre-compiled patterns for faster pbrk
    
    This combines the SSE4.2 instructions usage, with pre-compiled
    pattern searching usage, for a faster pbrk search method.
    
    Testing against large files of HTTP and SIP, there is about
    a 5% performance improvement by using pre-"compiled" patterns
    for guint8_pbrk() instead of passing it the search string and
    having it build the match array every time.
    Similar to regular expressions, "compiling" the pattern match array
    in advance only once and using the "compiled" patterns for
    the searches is faster than compiling it every time.
    
    Change-Id: Ifcbc14a6c93f32d15663a10d974bacdca5119a8e
    Ping-Bug: 10798
    Reviewed-on: https://code.wireshark.org/review/6990
    Petri-Dish: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  a618f1c   USB: put back interface class when dissecting URB_CONTROL
    adds  a837570   Combine SSE and pre-compiled patterns for faster pbrk


Summary of changes:
 debian/libwireshark0.symbols    |    3 +-
 debian/libwsutil0.symbols       |    3 +-
 epan/dissectors/packet-cups.c   |    8 ++-
 epan/dissectors/packet-irc.c    |   41 ++++++-------
 epan/dissectors/packet-megaco.c |   13 ++++-
 epan/dissectors/packet-sdp.c    |   12 +++-
 epan/dissectors/packet-sip.c    |   49 +++++++++++-----
 epan/tvbuff-int.h               |    2 +-
 epan/tvbuff.c                   |   56 +++++++++---------
 epan/tvbuff.h                   |   11 +++-
 epan/tvbuff_subset.c            |    4 +-
 frame_tvbuff.c                  |    4 +-
 wsutil/ws_mempbrk.c             |   60 ++++++++++---------
 wsutil/ws_mempbrk.h             |   27 +++++++--
 wsutil/ws_mempbrk_sse42.c       |  123 +++++++++++++--------------------------
 15 files changed, 222 insertions(+), 194 deletions(-)