Wireshark-commits: [Wireshark-commits] master 55eb35a: AMQP: Fix one warning from Clang Code Analys

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 6 Feb 2015 12:32:12 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=55eb35adc032423496bbd0e81112453d1d134a38
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

55eb35a by Petr Gotthard (petr.gotthard@xxxxxxxxxx):

    AMQP: Fix one warning from Clang Code Analysis
    
    Since 'values' is always 'length/4', we can have it as 'gint' and avoid
    the Clang warning concerning the while cycle.
    >> cannot optimize loop, the loop counter may overflow [-Wunsafe-loop-optimizations]
    
    Change-Id: I4342f9e3fcd5df7779f41414ab6f789fe402e3af
    Reviewed-on: https://code.wireshark.org/review/6979
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  eb85555   AMQP: Add more COL_INFO description for some packets/frames.
    adds  55eb35a   AMQP: Fix one warning from Clang Code Analysis


Summary of changes:
 epan/dissectors/packet-amqp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)