Wireshark-commits: [Wireshark-commits] master fb9dc13: MySQL: fix assert when the Connect Attrs cap

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 5 Feb 2015 08:53:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fb9dc13fb6e9b8e5ba6d15045694a9f1faf8f082
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fb9dc13 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    MySQL: fix assert  when the Connect Attrs capability is set, but no attributes
    
    From
    <http://dev.mysql.com/doc/internals/en/connection-phase-packets.html#packet-Protocol::HandshakeResponse>
    (emphasis mine):
    
    Starting with MySQL 5.6.6 the client **may** send attributes if CLIENT_CONNECT_ATTRS is set:
    
    Does this mean that the capability *may* be set, but the list of attributes can be empty?
    
    Issue reported by Peter Wu
    
    Ping-Bug:10351
    Change-Id: Ib83c27f4a15341f791c443471d7a3bdbd942aef4
    Reviewed-on: https://code.wireshark.org/review/6965
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  2bcd38f   ethercat: add default case in FoeFormatter
    adds  fb9dc13   MySQL: fix assert  when the Connect Attrs capability is set, but no attributes


Summary of changes:
 epan/dissectors/packet-mysql.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)