Wireshark-commits: [Wireshark-commits] master 0bf38f7: Lua: getting fieldinfo.value for FT_NONE cau

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 31 Dec 2014 06:34:26 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0bf38f7aec22a1a6e4acfbfec4a9a2201fd6f8de
Submitter: Hadriel Kaplan (hadrielk@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0bf38f7 by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    Lua: getting fieldinfo.value for FT_NONE causes assert
    
    Retrieving an FT_NONE field's value through `fieldinfo.value` or
    `fieldinfo()` causes an assert.  It should retrieve the label instead.
    
    Bug: 10815
    Change-Id: Ia80443f3dd046b2cc31d1dff70d599e96d6f6fe3
    Reviewed-on: https://code.wireshark.org/review/6150
    Petri-Dish: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Tested-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    

Actions performed:

    from  27be466   Do the full string in get_{compiled,runtime}_version_info().
    adds  0bf38f7   Lua: getting fieldinfo.value for FT_NONE causes assert


Summary of changes:
 epan/wslua/wslua_field.c |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)