Wireshark-commits: [Wireshark-commits] master-1.12 1c14653: Lua accessor for Protocol field type ge

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 30 Dec 2014 13:06:27 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1c14653021cb7d774356fb11ac0eb5d9fb4f1eca
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

1c14653 by Hadriel Kaplan (hadriel@xxxxxxxxxxxxxxxxx):

    Lua accessor for Protocol field type gets wrong data
    
    When a Lua dissector/tap accesses the value of a Field of FT_PROTOCOL ftype, the
    returned ByteArray contains the wrong data.  Also, calling such a field's
    tostring() method returns a string of "(unknown)" instead of the hex of the
    data.
    
    Bug: 10801
    Change-Id: I8a0642dc0e41af444d211bbe4106cd21207084a6
    Reviewed-on: https://code.wireshark.org/review/6003
    Reviewed-on: https://code.wireshark.org/review/6133
    Petri-Dish: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  474728d   Bug 10233 - Wireshark crashes if Lua heuristic dissector returns true
    adds  1c14653   Lua accessor for Protocol field type gets wrong data


Summary of changes:
 epan/wslua/wslua_field.c |   23 +++++++++++++++++++++--
 1 file changed, 21 insertions(+), 2 deletions(-)