Wireshark-commits: [Wireshark-commits] master 9fce4dd: If we can't open the GeoIP database, close a

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 28 Dec 2014 10:29:00 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9fce4dd4cb47965870d870b77983f8d2c501c810
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9fce4dd by Guy Harris (guy@xxxxxxxxxxxx):

    If we can't open the GeoIP database, close and unlink the map file.
    
    We can't write out the full map file, and we return an error, so just
    get rid of the file.
    
    Fixes Coverity CID 1256521.
    
    Change-Id: Ieee078f760c035d65b2fce199ea472ba915be9c6
    Reviewed-on: https://code.wireshark.org/review/6090
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  120628e   Don't check the same character twice in a row, check it and the next character.
    adds  9fce4dd   If we can't open the GeoIP database, close and unlink the map file.


Summary of changes:
 ui/traffic_table_ui.c |    6 ++++++
 1 file changed, 6 insertions(+)