Wireshark-commits: [Wireshark-commits] master-1.10 677d667: RSVP: RECORD_ROUTE IPv4 Subobject Flags

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 23 Dec 2014 13:25:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=677d667dcaed80faf8de7f3335a1cbcaf7497327
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

677d667 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    RSVP: RECORD_ROUTE IPv4 Subobject Flags field incorrect decoding
    
    The Flags field within RSVP RECORD_ROUTE IPv4_Subobject is decoded incorrectly.
    Wireshark thinks that 0x10 bit represents Node-ID, but actually the Node-ID is encoded by bit 0x20 (per RFC 4561)
    
    Issue reported by  Alexander Okonnikov
    
    Bug:10799
    Change-Id: I48f6aa35c08945aacf8f2bb871a72b5927511948
    Reviewed-on: https://code.wireshark.org/review/5944
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit f1038652c63e86c84c19c07bd018fb56e5c985e9)
    Reviewed-on: https://code.wireshark.org/review/6017
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  8827179   asn1/Makefile.nmake: packet-c1222.c not autogenerated using Windows nmake
    adds  677d667   RSVP: RECORD_ROUTE IPv4 Subobject Flags field incorrect decoding


Summary of changes:
 epan/dissectors/packet-rsvp.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)