URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=67cbafaa46b7d4f694efe10bd59dd761bc1fa4c4
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
67cbafa by Martin Kaiser (wireshark@xxxxxxxxx):
remove unnecessary integer overflow checks
... and don't call THROW() from a dissector
If we have a guint32 a and interpret 2*a as gint, we'll always end up
with a negative value if 2*a overflows. Both tvb_get_string_enc() and
proto_tree_add_item() handle this case and throw an exception.
Change-Id: Ibb142328837b6a583057531c76d08631fc731848
Reviewed-on: https://code.wireshark.org/review/5948
Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Actions performed:
from 9b3f9b7 Fix The left operand of '!=' is a garbage value issue found by Clang Analyzer
adds 67cbafa remove unnecessary integer overflow checks
Summary of changes:
epan/dissectors/packet-ms-mms.c | 27 ++++-----------------------
1 file changed, 4 insertions(+), 23 deletions(-)