Wireshark-commits: [Wireshark-commits] master c30aa11: Register the ORFEntry IP address as an IPv4

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 21 Dec 2014 23:36:08 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c30aa115fe6b69f73a06589d46b3eb90635cdde5
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c30aa11 by Guy Harris (guy@xxxxxxxxxxxx):

    Register the ORFEntry IP address as an IPv4 address.
    
    We're adding it with proto_tree_add_ipv4(), so that it's displayed as,
    and can be tested as, an IPv4 address.  That means that the field for it
    must be of type FT_IPv4, *even though it's calculated from an 8-bit
    prefix value* - you can't make it an FT_UINT8.
    
    Change-Id: I7d668fb2a707cdda4ad228afcbdcaf47ee6cba1b
    Reviewed-on: https://code.wireshark.org/review/5960
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  48419fc   Improve the message for "this field doesn't have the right type" assertions.
    adds  c30aa11   Register the ORFEntry IP address as an IPv4 address.


Summary of changes:
 epan/dissectors/packet-bgp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)