Wireshark-commits: [Wireshark-commits] master-1.10 e4b1a6f: Fix handling of 3-component OS version

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 20 Dec 2014 17:54:37 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e4b1a6f15a085cd49e45be1d9f8e2ebfa08c497e
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

e4b1a6f by Guy Harris (guy@xxxxxxxxxxxx):

    Fix handling of 3-component OS version numbers.
    
    Get rid of doubled square brackets (what were those for?), and match
    dots in the version number with "\.", so we only match dots.
    
    This fixes the handling of version numbers such as 10.10.1.
    
    (A 2-component version number doesn't match, but that's OK - the sed
    command doesn't use -n, so that just means it's unchanged by the
    command.)
    
    Change-Id: Ia4af97f2f323b88569a1dda6fe9e008c2e408642
    Reviewed-on: https://code.wireshark.org/review/5917
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  68e832f   Don't use WTAP_ERR_UNSUPPORTED for unwritable records.
    adds  e4b1a6f   Fix handling of 3-component OS version numbers.


Summary of changes:
 macosx-setup.sh |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)