Wireshark-commits: [Wireshark-commits] master abd90c3: Fix handling of 3-component OS version numbe

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 20 Dec 2014 17:47:53 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=abd90c32bbba16d848905b15f2b6ccfc353c8e41
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

abd90c3 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix handling of 3-component OS version numbers.
    
    Get rid of doubled square brackets (what were those for?), and match
    dots in the version number with "\.", so we only match dots.
    
    This fixes the handling of version numbers such as 10.10.1.
    
    (A 2-component version number doesn't match, but that's OK - the sed
    command doesn't use -n, so that just means it's unchanged by the
    command.)
    
    Change-Id: I3046133de732c80410592272d1f7b961a64d9289
    Reviewed-on: https://code.wireshark.org/review/5915
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  9ba9cd8   Qt: Add a CaptureFile class.
    adds  abd90c3   Fix handling of 3-component OS version numbers.


Summary of changes:
 macosx-setup.sh |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)