Wireshark-commits: [Wireshark-commits] master-1.10 12fd114: RDM: Mode verbose decoding of parameter

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 16 Dec 2014 15:06:25 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=12fd114c364d11fd28415ee9f17a5908ad3ccec1
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

12fd114 by zeuz (czingerl@xxxxxxxxx):

    RDM: Mode verbose decoding of parameter IDs.
        -> I don't see why they were uint8; ANSI E1.33 and ANSI E1.20 use uint16
    
    Change-Id: Ia2c024b503d6a4b8c18020699bdc676a8459dcbd
    Reviewed-on: https://code.wireshark.org/review/5783
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit db93414049b3094734e33a0da49f611c2a211410)
    Reviewed-on: https://code.wireshark.org/review/5785
    

Actions performed:

    from  be343af   Don't assert out on tvb_memcpy() with a null data pointer if the length is 0.
    adds  12fd114   RDM: Mode verbose decoding of parameter IDs.     -> I don't see why they were uint8; ANSI E1.33 and ANSI E1.20 use uint16


Summary of changes:
 epan/dissectors/packet-rdm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)