Wireshark-commits: [Wireshark-commits] master-1.12 edc1a29: LPP: avoid doing an out of bound access

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 12 Dec 2014 14:28:18 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=edc1a29b9efe9e4298a80550ac71a78abc8f0511
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

edc1a29 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    LPP: avoid doing an out of bound access in case the PER decoding gives an invalid value
    
    Bug: 10773
    Change-Id: I4fcde84d7be1e42729b6ec0763064e9885951468
    Reviewed-on: https://code.wireshark.org/review/5729
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    (cherry picked from commit 8e96830156bea314207b97315ccebd605317f142)
    Reviewed-on: https://code.wireshark.org/review/5730
    

Actions performed:

    from  adee1a4   LCSAP: fix dissection of negative longitude and latitude
    adds  edc1a29   LPP: avoid doing an out of bound access in case the PER decoding gives an invalid value


Summary of changes:
 asn1/lpp/lpp.cnf             |    4 +-
 epan/dissectors/packet-lpp.c |  144 +++++++++++++++++++++---------------------
 2 files changed, 76 insertions(+), 72 deletions(-)