Wireshark-commits: [Wireshark-commits] master 4af7482: Eliminate proto_tree_add_text from packet-ic

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 10 Dec 2014 06:00:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4af7482baf3997b38d4b110250b37bcd3ea004ba
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4af7482 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Eliminate proto_tree_add_text from packet-icq.c
    
    Change-Id: I2f4bcd8c4a6cf534bb5b6b5c5aa7e21075968ee3
    Reviewed-on: https://code.wireshark.org/review/5696
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  c449b43   nfs: expert...() shouldn't be called under 'if(tree)'
    adds  4af7482   Eliminate proto_tree_add_text from packet-icq.c


Summary of changes:
 epan/dissectors/packet-icq.c |  433 +++++++++++++++++++++++-------------------
 1 file changed, 235 insertions(+), 198 deletions(-)