Wireshark-commits: [Wireshark-commits] master fbf08cf: Nothing to free there.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 9 Dec 2014 04:04:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fbf08cffec52af67ba69858b0ca23ce92789d00c
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fbf08cf by Guy Harris (guy@xxxxxxxxxxxx):

    Nothing to free there.
    
    pcapng_read_block() never sets *err_info if it returns
    PCAPNG_BLOCK_NOT_SHB - that happens on an EOF, a short read, or on a
    successful read of something that doesn't look like an SHB.
    
    Change-Id: I23ad6aa1c95d800b068a798a4aad1d70d07ac281
    Reviewed-on: https://code.wireshark.org/review/5686
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  7b1c3ab   Manually fix a pidl bug - that field should be an FT_STRING.
    adds  fbf08cf   Nothing to free there.


Summary of changes:
 wiretap/pcapng.c |    1 -
 1 file changed, 1 deletion(-)