Wireshark-commits: [Wireshark-commits] master b98c570: Fix varargs handling in col_{add, append}_ls

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 5 Dec 2014 21:05:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b98c570969870f1b0aec9c4165d35ab9c5db8673
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b98c570 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix varargs handling in col_{add,append}_lstr().
    
    We do multiple va_start() calls using the first string in the list of
    strings; do *not* use the first-string argument to iterate over all the
    argument strings, as that means that only the first va_start() call will
    do the right thing, use a separate variable.
    
    Bug: 10755
    Change-Id: Ic4a6c24f911e335d147883a25d30289628836875
    Reviewed-on: https://code.wireshark.org/review/5630
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  18fabb4   Strengthen association matching when we haven't seen the INIT/INIT-ACK.
    adds  b98c570   Fix varargs handling in col_{add,append}_lstr().


Summary of changes:
 epan/column-utils.c |   12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)