Wireshark-commits: [Wireshark-commits] master 417c181: Use guint8 for 8-bit unsigned numeric values

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 28 Oct 2014 18:37:12 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=417c181afba7e5ac6573660875f5ba5f03e671cb
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

417c181 by Guy Harris (guy@xxxxxxxxxxxx):

    Use guint8 for 8-bit unsigned numeric values.
    
    That slightly better expresses the intent.
    
    Also, fix the message printed for bad bytes in a field name to handle
    bytes that are bad because they don't correspond to printable ASCII
    characters.
    
    Change-Id: I01f232c35bbbe30286999b6c607bfcf3d491453d
    Reviewed-on: https://code.wireshark.org/review/4976
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  8ea4df9   Use g_ascii_isalnum() rather than isalnum().
    adds  417c181   Use guint8 for 8-bit unsigned numeric values.


Summary of changes:
 epan/asm_utils.c |    2 +-
 epan/proto.c     |    7 +++++--
 2 files changed, 6 insertions(+), 3 deletions(-)