Wireshark-commits: [Wireshark-commits] master 8ea4df9: Use g_ascii_isalnum() rather than isalnum().

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 28 Oct 2014 18:19:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8ea4df97e052f3fb0af3336990f2bef6d882b258
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8ea4df9 by Guy Harris (guy@xxxxxxxxxxxx):

    Use g_ascii_isalnum() rather than isalnum().
    
    Only *ASCII* alphanumerics are allowed in filterable field names, so use
    g_ascii_isalnum() to check for them.  That avoids issues with characters
    with the 8th bit set and avoids locale-dependent behavior.
    
    Change-Id: I4e3c4eec907f5e576629229fcf154fcf728b7a2e
    Reviewed-on: https://code.wireshark.org/review/4973
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  bab44ad   Add some new features to the list and regenerate NEWS.
    adds  8ea4df9   Use g_ascii_isalnum() rather than isalnum().


Summary of changes:
 epan/oids.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)