URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=41f6923b3049dfb57bef544a4c580f256f807e85
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
41f6923 by Evan Huus (eapache@xxxxxxxxx):
ncp2222: initialize buffer in build_expert_data
We do a bunch of conditional logic to fill in the buffer, and then were checking
strlen(buffer) to see if we'd actually filled it in or not, but if we hadn't
then the buffer was garbage and strlen(buffer) was throwing valgrind warnings.
Ensure this works as intended by setting the first byte of the buffer
unconditionally at the beginning, so strlen(buffer) returns 0 as expected in
that case.
Bug: 10628
Change-Id: I6f6c29fbbcb601b6ebccb3a4b312f0fa72c169ae
Reviewed-on: https://code.wireshark.org/review/4924
Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
Actions performed:
from 88d1bba Italian translation fixes
adds 41f6923 ncp2222: initialize buffer in build_expert_data
Summary of changes:
epan/dissectors/packet-ncp2222.inc | 1 +
1 file changed, 1 insertion(+)