URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c4dc9eda8013ae0af0fe41fddc63d09eb7197bd7
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
c4dc9ed by Guy Harris (guy@xxxxxxxxxxxx):
Handle an hfindex of -1.
Code generated by the current version of Pidl dissects bitset fields
twice - once with proto_tree_add_item(), which puts the actual item into
the tree, so that we can create a subtree under it, and once with a
dissect_dcerpc_{type}() routine, to fetch the value and step past the
field. The second call passes an hf_ index value of -1; interpret that
as meaning "don't put this into the protocol tree", rather than just
blindly calling proto_tree_add_XXX with -1 and getting a dissector
assertion.
Change-Id: I42fc023e77514a8a8a25d5c9db11fa3ef053babf
Reviewed-on: https://code.wireshark.org/review/4892
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from 7522497 With CMake, define WANT_PACKET_EDITOR in config.h.
adds c4dc9ed Handle an hfindex of -1.
Summary of changes:
epan/dissectors/packet-dcerpc.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)