Wireshark-commits: [Wireshark-commits] master c3f14ab: Don't use toupper() in the test program.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 20 Oct 2014 09:04:47 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c3f14ab3d4433ce95cd326176faa187a5ad3eba1
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c3f14ab by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use toupper() in the test program.
    
    We're not including ctype.h in the test program, so don't use toupper().
    The test program might not be built with GLib, so don't use
    g_ascii_toupper(), either.  Just compare against both 'Y' and 'y'.
    
    Change-Id: Iabc04a5fecb04110c0d16b24a047de72eabbb2bc
    Reviewed-on: https://code.wireshark.org/review/4870
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  991743b   Get rid of another toupper() call in favor of g_ascii_toupper().
    adds  c3f14ab   Don't use toupper() in the test program.


Summary of changes:
 epan/except.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)