Wireshark-commits: [Wireshark-commits] master-1.12 794502d: Don't use <ctype.h> macros.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 20 Oct 2014 08:56:37 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=794502da16663fd57e8d816f5e8049ba2ec89060
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

794502d by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use <ctype.h> macros.
    
    They're locale-dependent (although those *particular* ones might not
    be).
    
    Remove no-longer necessary (or not-even-necessary-before-this-change)
    includes of <ctype.h>
    
    Change-Id: I1384e3ae4ccba6af9220a08773abcde7ea320573
    Reviewed-on: https://code.wireshark.org/review/4755
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 0d9b449ae95f26e86f8b433c7f4f99341443b048)
    Reviewed-on: https://code.wireshark.org/review/4868
    

Actions performed:

    from  0a01c2d   Get rid of another toupper() call in favor of g_ascii_toupper().
    adds  794502d   Don't use <ctype.h> macros.


Summary of changes:
 epan/ftypes/ftype-bytes.c  |    1 -
 epan/ftypes/ftype-guid.c   |    3 +--
 epan/ftypes/ftype-string.c |    1 -
 epan/ftypes/ftype-time.c   |    5 ++---
 4 files changed, 3 insertions(+), 7 deletions(-)