URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3e9482f54387f6ceb2014de669bbe1f695897acb
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark
Commits:
3e9482f by Guy Harris (guy@xxxxxxxxxxxx):
Get rid of calls to ctype.h functions.
They don't handle values outside the range -1 to 127, and their behavior
is locale-dependent. Use g_ascii_isXXX() and g_ascii_toXXX() instead of
isXXX() and toXXX().
If you're checking for printable ASCII, don't use isascii() and don't
use iscntrl(), use g_ascii_isprint(). If you're checking for graphical
ASCII, i.e. printable ASCII except for a space, use g_ascii_isgraph().
(cherry picked from commit 80e6f6251e96dd7b8a9ab0fdbf63b03a73ef6692)
Change-Id: Iabf1304205850934e1b880c0bb81064c76dcd06f
Reviewed-on: https://code.wireshark.org/review/4853
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from c72b3c3 Eliminate a use of a ctype.h function.
adds 3e9482f Get rid of calls to ctype.h functions.
Summary of changes:
epan/dissectors/packet-aprs.c | 9 +-
epan/dissectors/packet-beep.c | 3 +-
epan/dissectors/packet-catapult-dct2000.c | 5 +-
epan/dissectors/packet-cups.c | 10 +-
epan/dissectors/packet-diameter.c | 3 +-
epan/dissectors/packet-ftp.c | 13 +-
epan/dissectors/packet-giop.c | 13 +-
epan/dissectors/packet-http.c | 17 +-
epan/dissectors/packet-icap.c | 19 +-
epan/dissectors/packet-imap.c | 7 +-
epan/dissectors/packet-imf.c | 16 +-
epan/dissectors/packet-irc.c | 25 +-
epan/dissectors/packet-megaco.c | 15 +-
epan/dissectors/packet-mgcp.c | 5 +-
epan/dissectors/packet-mrcpv2.c | 3 +-
epan/dissectors/packet-msrp.c | 7 +-
epan/dissectors/packet-multipart.c | 5 +-
epan/dissectors/packet-ntlmssp.c | 5 +-
epan/dissectors/packet-pvfs2.c | 3 +-
epan/dissectors/packet-rtsp.c | 37 +-
epan/dissectors/packet-sip.c | 1519 ++++++++++++++++++++++++++++-
epan/dissectors/packet-smb-pipe.c | 5 +-
epan/dissectors/packet-smtp.c | 5 +-
epan/dissectors/packet-syslog.c | 3 +-
epan/dissectors/packet-tpkt.c | 6 +-
epan/dissectors/packet-xcsl.c | 5 +-
26 files changed, 1613 insertions(+), 150 deletions(-)