Wireshark-commits: [Wireshark-commits] master 975b02f: Converted numerous proto_tree_add_none_forma

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 18 Oct 2014 12:29:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=975b02f879ca1407f40fdf5c3b446edcaa5171a2
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

975b02f by David Ameiss (netshark@xxxxxxxxxxxxx):

    Converted numerous proto_tree_add_none_format() calls for bitmask/flag items to proto_tree_add_bitmask().
    Correctly set the length of LBT-RM and LBT-RU header blocks.
    Various other cosmetic cleanups.
    
    Change-Id: If19bbdeb10176b8059fd4cf657719b3b9817bc6a
    Reviewed-on: https://code.wireshark.org/review/4776
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  01cf7fe   Add URL to a description of the attributes Add comments about additional attributes
    adds  975b02f   Converted numerous proto_tree_add_none_format() calls for bitmask/flag items to proto_tree_add_bitmask(). Correctly set the length of LBT-RM and LBT-RU header blocks. Various other cosmetic cleanups.


Summary of changes:
 epan/dissectors/packet-lbmc.c   | 1788 ++++++++++++++++++---------------------
 epan/dissectors/packet-lbmpdm.c |   34 +-
 epan/dissectors/packet-lbmr.c   |  646 +++++++-------
 epan/dissectors/packet-lbtrm.c  |   88 +-
 epan/dissectors/packet-lbtru.c  |  104 +--
 5 files changed, 1181 insertions(+), 1479 deletions(-)