Wireshark-commits: [Wireshark-commits] master-1.12 c734c57: Don't use ctype.h routines.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 18 Oct 2014 01:16:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c734c57a37e4a84e8b66cc054d4b2c07aecebc9e
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

c734c57 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use ctype.h routines.
    
    That eliminates locale-dependent behavior when parsing packets.
    
    While we're at it, rename a variable to reflect what it's being used for.
    
    Change-Id: I672553c784edf73f826dad993d7c47c3b545b506
    Reviewed-on: https://code.wireshark.org/review/4807
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  a635986   Get rid of some no-longer-necessary casts.
    adds  c734c57   Don't use ctype.h routines.


Summary of changes:
 asn1/s1ap/packet-s1ap-template.c |    1 -
 asn1/s1ap/s1ap.cnf               |   10 +++++-----
 epan/dissectors/packet-s1ap.c    |   25 ++++++++++++-------------
 3 files changed, 17 insertions(+), 19 deletions(-)