Wireshark-commits: [Wireshark-commits] master-1.12 a635986: Get rid of some no-longer-necessary cas

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 18 Oct 2014 00:00:41 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a6359868370cadb4e631f506aafb0e0819e890b7
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

a635986 by Guy Harris (guy@xxxxxxxxxxxx):

    Get rid of some no-longer-necessary casts.
    
    g_ascii_isXXX() can be handed a char value safely; they won't try to use
    it as an index into a table before checking it.
    
    (cherry picked from commit e3477bd13635a637d1337093457dbad499bd5538)
    
    Change-Id: I5a94f2d2ddb88a99e755c0ffbaed61547066ce66
    Reviewed-on: https://code.wireshark.org/review/4802
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  a82c849   Don't use ctype.h routines.
    adds  a635986   Get rid of some no-longer-necessary casts.


Summary of changes:
 capture_opts.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)