Wireshark-commits: [Wireshark-commits] master a91799e: Don't use ctype.h routines.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 17 Oct 2014 23:43:12 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a91799ebfa3a3aac705132722e57acc92fe4eddb
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a91799e by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use ctype.h routines.
    
    That avoids locale dependency and handles possibly-signed chars(which
    we weren't always doing before).
    
    Change-Id: I89e50678abb8c3e535081c92ca25bc1bab672c68
    Reviewed-on: https://code.wireshark.org/review/4798
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  19b7819   Get rid of unnecessary includes of ctype.h.
    adds  a91799e   Don't use ctype.h routines.


Summary of changes:
 capture_opts.c  |    9 ++++-----
 color_filters.c |    5 ++---
 fileset.c       |    3 +--
 rawshark.c      |    1 -
 text2pcap.c     |    3 +--
 5 files changed, 8 insertions(+), 13 deletions(-)