Wireshark-commits: [Wireshark-commits] master 35a9b98: Use proto_tree_add_bitmask for ExpandedNodeI

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 17 Oct 2014 16:04:12 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=35a9b9813879fff308c838f8a4351abfeafa8a4a
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

35a9b98 by Hannes Mezger (hannes.mezger@xxxxxxxxxxx):

    Use proto_tree_add_bitmask for ExpandedNodeId EncodingMask
    
    Instead of adding the items using proto_tree_add_item, use proto_tree_add_bitmask in parseExpandedNodeId(). Also, the redundant 'NodeId ' text is removed from hf_opcua_nodeid_... items for better readability.
    
    Change-Id: Ie68f1d280dd733fd2eede0b2b73ad8d7f28396b3
    Reviewed-on: https://code.wireshark.org/review/4730
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  17a1a0d   SGsAP Update to V12.6.0 except for IE TMSI based NRI container.
    adds  35a9b98   Use proto_tree_add_bitmask for ExpandedNodeId EncodingMask


Summary of changes:
 plugins/opcua/opcua_simpletypes.c |   25 ++++++++++++++++---------
 1 file changed, 16 insertions(+), 9 deletions(-)