Wireshark-commits: [Wireshark-commits] master 44d4339: Don't use <ctype.h> macros, and eliminate an

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 17 Oct 2014 06:22:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=44d4339eb335b6d6f7a8ffad6846e82aba90b233
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

44d4339 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use <ctype.h> macros, and eliminate an include of <ctype.h>.
    
    This avoids locale-dependent tests, and fixes cases where we passed
    signed char values to those macros (which is not safe with char being
    signed, as it is on most, but not all, platforms).
    
    Change-Id: I51d9716fe3eb02a6e98208334285c07597a6be79
    Reviewed-on: https://code.wireshark.org/review/4761
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  25d9a7b   Don't use <ctype.h> macros, and eliminate an include of <ctype.h>.
    adds  44d4339   Don't use <ctype.h> macros, and eliminate an include of <ctype.h>.


Summary of changes:
 epan/wslua/wslua_struct.c |   11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)