Wireshark-commits: [Wireshark-commits] master-1.12 50c1519: Don't use ctype.h routines.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 17 Oct 2014 06:02:43 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=50c1519a649816123074d8b6368ee00a6f260e06
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

50c1519 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use ctype.h routines.
    
    That avoids locale dependency and handles possibly-signed chars (which
    we weren't doing before).
    
    Change-Id: I2afab254044e0d39dfa67acd840b9fe4ff1e6d08
    Reviewed-on: https://code.wireshark.org/review/4756
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 762b8d78ecc001f968b3e0b5f73c22eac4c091ea)
    Reviewed-on: https://code.wireshark.org/review/4757
    

Actions performed:

    from  f2859a5   Use g_ascii_isalnum() rather than isalnum().
    adds  50c1519   Don't use ctype.h routines.


Summary of changes:
 epan/wslua/lrexlib.c |   11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)