Wireshark-commits: [Wireshark-commits] master f249589: Just have get_mac_lte_rapid_description() re

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 16 Oct 2014 23:04:28 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f249589938de63bab963ebf56bcfda3ac9ed2503
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f249589 by Guy Harris (guy@xxxxxxxxxxxx):

    Just have get_mac_lte_rapid_description() return the description string.
    
    If get_mac_lte_rapid_description() returned FALSE, we always used "" as
    the description string; just have it return the string, or return "" if
    rapid ranges haven't been configured, and just use the string.
    
    (If the code ever needs to determine in other places whether rapid ranges
    have been configured, it can check s_rapid_ranges_configured, or
    get_mac_lte_rapid_description() could return NULL in that case and the
    code using the string can check for a null value.)
    
    This should squelch some incorrect used-but-not-set warnings from at
    least one compiler.
    
    Change-Id: I3ed495a4beb4a553e453e7bca764d1d8a07c5e53
    Reviewed-on: https://code.wireshark.org/review/4750
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  a517d50   Make sort_alphabet() not fail too badly with characters in [128,255].
    adds  f249589   Just have get_mac_lte_rapid_description() return the description string.


Summary of changes:
 epan/dissectors/packet-mac-lte.c |   28 ++++++++++++----------------
 1 file changed, 12 insertions(+), 16 deletions(-)