Wireshark-commits: [Wireshark-commits] master-1.12 d956cd2: Make sort_alphabet() not fail too badly

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 16 Oct 2014 21:59:35 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d956cd28444e41a04574bd0fa2ca91bbeb96f2bb
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

d956cd2 by Guy Harris (guy@xxxxxxxxxxxx):

    Make sort_alphabet() not fail too badly with characters in [128,255].
    
    Treat all values in the alphabet as unsigned.
    
    Change-Id: I4476c75352f32673a9cd131ea233465f3376fa25
    Reviewed-on: https://code.wireshark.org/review/4747
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit a517d500b4d5bdedba68127d295a37c2dbe4bf2c)
    Reviewed-on: https://code.wireshark.org/review/4748
    

Actions performed:

    from  b8bb518   Oops, I missed one "cast a char to int and use it as a subscript" case.
    adds  d956cd2   Make sort_alphabet() not fail too badly with characters in [128,255].


Summary of changes:
 epan/dissectors/packet-per.c |   12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)