Wireshark-commits: [Wireshark-commits] master 71a42e0: Oops, I missed one "cast a char to int and u

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 16 Oct 2014 20:04:31 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=71a42e0fbcc8ac838f936dd88e05681ef07f2bbf
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

71a42e0 by Guy Harris (guy@xxxxxxxxxxxx):

    Oops, I missed one "cast a char to int and use it as a subscript" case.
    
    Casting a signed char with a negative value to int will preserve the
    value, so it'll still be a negative subscript.  Cast to guchar instead,
    to make sure 0x80 through 0xFF are treated as 128 to 255, not -128 to
    -1.
    
    Change-Id: I1f0b33ba3686e963d45317b45465ff335431d17f
    Reviewed-on: https://code.wireshark.org/review/4742
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f6bc6f9   Better fix - just check that the upper and lower nibbles are >= 0xA.
    adds  71a42e0   Oops, I missed one "cast a char to int and use it as a subscript" case.


Summary of changes:
 epan/strutil.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)