Wireshark-commits: [Wireshark-commits] master-1.10 6596e08: gchar is not guaranteed to be signed; u

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 16 Oct 2014 18:47:10 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6596e08da3cd74b10904ed2568577c0d4940298f
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

6596e08 by Guy Harris (guy@xxxxxxxxxxxx):

    gchar is not guaranteed to be signed; use gint8.
    
    C does not guarantee that char is signed (that's why there's a keyword
    "signed").  Use gint8, to indicate that it's not a character, it's an
    8-bit signed integer.
    
    Change-Id: Id632df23352840cbc86a4d88f4c7dade95ab7837
    Reviewed-on: https://code.wireshark.org/review/4736
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 0db468e300287b8c8ee691f23873b299f64da0c7)
    Reviewed-on: https://code.wireshark.org/review/4738
    

Actions performed:

    from  18c5a32   Fix issues in some ARM compilers, due to char being unsigned?
    adds  6596e08   gchar is not guaranteed to be signed; use gint8.


Summary of changes:
 airpcap.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)