URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2a8216a4cd8bbb651ef181cde7539ae5069a0a92
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark
Commits:
2a8216a by Guy Harris (guy@xxxxxxxxxxxx):
Fix some more "char is unsigned" issues, and a possible "char is signed" one.
C neither guarantees that char is signed nor that it's unsigned. Make
the str_to_nibble tables arrays of gint8, to make sure they can hold
numbers between 0 and 15 as well as -1. Cast gchar to guchar, not int,
when using it as a subscript into that array, so that the subscripts are
in the range 0 to 255, not -128 to 127.
Change-Id: Ib85de5aa4e83ae9efd808c78ce3f86f45b4a3f2a
Reviewed-on: https://code.wireshark.org/review/4734
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
(cherry picked from commit 50add40a2da49178fd784b063e44d59208d40d02)
Reviewed-on: https://code.wireshark.org/review/4735
Actions performed:
from f773e82 Fix issues in some ARM compilers, due to char being unsigned?
adds 2a8216a Fix some more "char is unsigned" issues, and a possible "char is signed" one.
Summary of changes:
epan/strutil.c | 8 ++++----
epan/wslua/wslua_internals.c | 8 ++++----
2 files changed, 8 insertions(+), 8 deletions(-)