Wireshark-commits: [Wireshark-commits] master-1.12 f773e82: Fix issues in some ARM compilers, due t

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 16 Oct 2014 18:07:14 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f773e829aa041a43a9a74c5ef037576b4aabc986
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

f773e82 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix issues in some ARM compilers, due to char being unsigned?
    
    I'm not 100% certain the comparisons were right even with signed char;
    make the comparisons unsigned vs. unsigned, regardless of whether char
    is signed or not.  (No, C doesn't require it to be signed; that's why
    there's a "signed" keyword.)
    
    Change-Id: Icbbd1019a2f7d4ebb40d821255834f825cd7c5a7
    Reviewed-on: https://code.wireshark.org/review/4731
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 353f6258f92ed7f8787cc32cd92ac3d44aa88f21)
    Reviewed-on: https://code.wireshark.org/review/4732
    

Actions performed:

    from  be26f8e   Don't allocate the interfaces array until we've read the SHB.
    adds  f773e82   Fix issues in some ARM compilers, due to char being unsigned?


Summary of changes:
 epan/ftypes/ftype-pcre.c |   25 +++++++++++++++++--------
 1 file changed, 17 insertions(+), 8 deletions(-)