Wireshark-commits: [Wireshark-commits] master-1.10 1a7884e: Don't allocate the interfaces array unt

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 16 Oct 2014 00:03:18 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1a7884e11fe48e8cb910113a00a5711078ea1a68
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

1a7884e by Guy Harris (guy@xxxxxxxxxxxx):

    Don't allocate the interfaces array until we've read the SHB.
    
    Nothing from the SHB gets stored in the interfaces array - it's filled
    in from IDBs - so it doesn't need to exist when we read the first SHB,
    and thus doesn't need to be freed if the attempt to read the SHB gets an
    error or a "this isn't a pcap-ng file" indication.
    
    Change-Id: I7e8c573efa67383c843177413cf5f3e2e279502c
    Reviewed-on: https://code.wireshark.org/review/4713
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  7954467   NCP: cast to guint instead of gulong
    adds  1a7884e   Don't allocate the interfaces array until we've read the SHB.


Summary of changes:
 wiretap/pcapng.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)