Wireshark-commits: [Wireshark-commits] master-1.12 6fa8338: ncp2222: don't overflow buffer construc

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 13 Oct 2014 17:00:52 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6fa8338b381c0018f8dcc8286c554903a5fa4cb8
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

6fa8338 by Evan Huus (eapache@xxxxxxxxx):

    ncp2222: don't overflow buffer constructing string
    
    Fixes stack-smashing vuln.
    
    Somehow there was already an XXX in the code about this, but nobody realized at
    the time it was worth fixing... really?
    
    Bug: 10552
    Change-Id: I849068bd6c45146339444f295b72430d3c6e08f2
    Reviewed-on: https://code.wireshark.org/review/4653
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    (cherry picked from commit b9988e2bbfc7c6c41ef82c559bd11a8c19170491)
    Reviewed-on: https://code.wireshark.org/review/4654
    

Actions performed:

    from  fafe1f3   SPDY: Fix bitmask for priority bit
    adds  6fa8338   ncp2222: don't overflow buffer constructing string


Summary of changes:
 epan/dissectors/packet-ncp2222.inc |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)