Wireshark-commits: [Wireshark-commits] master 4f4e01b: Don't treat int return values as valid wtap_

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 10 Oct 2014 01:14:40 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4f4e01b36bbe60b4ac1e486c8f6891cb6a07a24b
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4f4e01b by Guy Harris (guy@xxxxxxxxxxxx):

    Don't treat int return values as valid wtap_open_return_val values.
    
    They happen to be, at least now, but that's not valid in C++, and it's
    probably unwise in any case.
    
    Change-Id: Ifd49920cfaa376e5e7788329ee83db3956a7cdff
    Reviewed-on: https://code.wireshark.org/review/4585
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  9754192   Cast size_t to to gulong as the length argument to g_snprintf().
    adds  4f4e01b   Don't treat int return values as valid wtap_open_return_val values.


Summary of changes:
 wiretap/peektagged.c |   18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)