Wireshark-commits: [Wireshark-commits] master 45e4629: Use an enum for the open-routine return valu

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 9 Oct 2014 23:45:33 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=45e462985db891248ffcb9db21e6b66733de0b84
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

45e4629 by Guy Harris (guy@xxxxxxxxxxxx):

    Use an enum for the open-routine return value, as per Evan Huus's suggestion.
    
    Clean up some things we ran across while making those changes.
    
    Change-Id: Ic0d8943d36e6e120d7af0a6148fad98015d1e83e
    Reviewed-on: https://code.wireshark.org/review/4581
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  112c90a   Kerberos: fix decryption of DCERPC with Kerberos encryption
    adds  45e4629   Use an enum for the open-routine return value, as per Evan Huus's suggestion.


Summary of changes:
 epan/wslua/wslua_file.c       |   12 ++++-----
 wiretap/5views.c              |   19 +++++++-------
 wiretap/aethra.c              |   12 ++++-----
 wiretap/ascendtext.c          |   12 ++++-----
 wiretap/ber.c                 |   14 +++++-----
 wiretap/btsnoop.c             |   22 ++++++++--------
 wiretap/camins.c              |   10 +++----
 wiretap/catapult_dct2000.c    |   18 ++++++-------
 wiretap/commview.c            |   12 ++++-----
 wiretap/cosine.c              |   10 +++----
 wiretap/csids.c               |   25 +++++++++---------
 wiretap/daintree-sna.c        |   23 +++++++---------
 wiretap/dbs-etherwatch.c      |    8 +++---
 wiretap/dct3trace.c           |   10 +++----
 wiretap/erf.c                 |   42 ++++++++++++++---------------
 wiretap/eyesdn.c              |   10 +++----
 wiretap/file_access.c         |   58 ++++++++++++++++++++---------------------
 wiretap/hcidump.c             |   18 ++++++-------
 wiretap/i4btrace.c            |   12 ++++-----
 wiretap/ipfix.c               |   47 ++++++++++++++-------------------
 wiretap/iptrace.c             |   10 +++----
 wiretap/iseries.c             |   28 ++++++++++----------
 wiretap/k12.c                 |   34 ++++++++++++------------
 wiretap/k12text.l             |    8 +++---
 wiretap/lanalyzer.c           |   32 +++++++++++------------
 wiretap/libpcap.c             |   24 ++++++++---------
 wiretap/logcat.c              |   24 ++++++++---------
 wiretap/logcat_text.c         |   10 +++----
 wiretap/mime_file.c           |   14 +++++-----
 wiretap/mp2t.c                |   27 +++++++++----------
 wiretap/mpeg.c                |   12 ++++-----
 wiretap/netmon.c              |   26 +++++++++---------
 wiretap/netscaler.c           |   19 +++++++-------
 wiretap/netscreen.c           |   10 +++----
 wiretap/nettl.c               |   18 ++++++-------
 wiretap/network_instruments.c |   30 ++++++++++-----------
 wiretap/netxray.c             |   38 +++++++++++++--------------
 wiretap/ngsniffer.c           |   26 +++++++++---------
 wiretap/packetlogger.c        |   16 ++++++------
 wiretap/pcapng.c              |   16 ++++++------
 wiretap/peekclassic.c         |   22 ++++++++--------
 wiretap/peektagged.c          |   36 ++++++++++++-------------
 wiretap/pppdump.c             |   12 ++++-----
 wiretap/radcom.c              |   55 +++++++++++++++++++-------------------
 wiretap/snoop.c               |   24 ++++++++---------
 wiretap/stanag4607.c          |   10 +++----
 wiretap/tnef.c                |    8 +++---
 wiretap/toshiba.c             |    8 +++---
 wiretap/visual.c              |   16 ++++++------
 wiretap/vms.c                 |    8 +++---
 wiretap/vwr.c                 |    8 +++---
 wiretap/wtap.h                |   27 ++++++++++++-------
 52 files changed, 521 insertions(+), 529 deletions(-)