Wireshark-commits: [Wireshark-commits] master 3ee8efd: Be less lazy about disabling a Visual C++ wa

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 8 Oct 2014 22:50:20 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3ee8efdfea3492ca3c6a31dc89935dd70d8348b0
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3ee8efd by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Be less lazy about disabling a Visual C++ warning.
    
    As Graham pointed out, "#pragma warning(disable..." affects the rest
    of the file. Add a push+pop so that we only operate on the line in
    question. Ideally we'd be able to use "suppress" but an "#endif"
    prevents that.
    
    Change-Id: Ia01d6c245879f1c845dc68c18caea2cbceb273ef
    Reviewed-on: https://code.wireshark.org/review/4569
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  d1ec1e8   Use WTAP_ERR_DECOMPRESS for decompression errors.
    adds  3ee8efd   Be less lazy about disabling a Visual C++ warning.


Summary of changes:
 ui/qt/simple_dialog.cpp |    4 ++++
 1 file changed, 4 insertions(+)