Wireshark-commits: [Wireshark-commits] master 21e844b: Use WTAP_ERR_BAD_FILE for malformed compress

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 8 Oct 2014 20:50:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=21e844bd82783a753235a770c1259ac645108e41
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

21e844b by Guy Harris (guy@xxxxxxxxxxxx):

    Use WTAP_ERR_BAD_FILE for malformed compressed data in DOS Sniffer files.
    
    Get rid of WTAP_ERR_UNC_TRUNCATED and WTAP_ERR_UNC_BAD_OFFSET, and lump
    them under WTAP_ERR_BAD_FILE, with an error string; they're just another
    form of "this file isn't a valid file of the type in question".
    
    Change-Id: I0e9ac7c2ee66c8d789234a301c1dc2173aef1312
    Reviewed-on: https://code.wireshark.org/review/4562
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  c303a2e   Make sure we don't dereference a null pointer.
    adds  21e844b   Use WTAP_ERR_BAD_FILE for malformed compressed data in DOS Sniffer files.


Summary of changes:
 wiretap/ngsniffer.c |   20 +++++++++++++-------
 wiretap/wtap.c      |    6 ------
 wiretap/wtap.h      |   26 ++++++++++----------------
 3 files changed, 23 insertions(+), 29 deletions(-)